Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call index from the cross-chain interface #961

Merged
merged 131 commits into from
Oct 18, 2023
Merged

Remove call index from the cross-chain interface #961

merged 131 commits into from
Oct 18, 2023

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Sep 8, 2023

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (f6a0e86) 77.12% compared to head (194c7dd) 76.42%.

❗ Current head 194c7dd differs from pull request most recent head 6d37669. Consider uploading reports for the commit 6d37669 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   77.12%   76.42%   -0.71%     
==========================================
  Files          44       45       +1     
  Lines        1836     1879      +43     
  Branches       72       76       +4     
==========================================
+ Hits         1416     1436      +20     
- Misses        401      424      +23     
  Partials       19       19              
Flag Coverage Δ
rust 77.56% <56.66%> (-0.08%) ⬇️
solidity 71.58% <100.00%> (-3.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/src/Assets.sol 67.85% <100.00%> (ø)
contracts/src/Gateway.sol 78.37% <100.00%> (-2.43%) ⬇️
parachain/pallets/control/src/lib.rs 98.94% <ø> (ø)
parachain/pallets/inbound-queue/src/lib.rs 65.90% <100.00%> (+0.79%) ⬆️
parachain/primitives/core/src/outbound.rs 30.48% <ø> (ø)
parachain/primitives/router/src/inbound/mod.rs 58.41% <55.68%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong self-assigned this Sep 8, 2023
@yrong yrong requested a review from vgeddes September 11, 2023 04:09
@yrong yrong marked this pull request as draft September 11, 2023 10:26
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/pallets/inbound-queue/src/lib.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/inbound/mod.rs Outdated Show resolved Hide resolved
parachain/pallets/inbound-queue/src/test.rs Outdated Show resolved Hide resolved
parachain/pallets/inbound-queue/src/lib.rs Outdated Show resolved Hide resolved
parachain/pallets/inbound-queue/src/lib.rs Show resolved Hide resolved
Base automatically changed from vincent/outbound-fees to main October 17, 2023 10:32
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this in 🚀

@yrong yrong merged commit 08ff3d6 into main Oct 18, 2023
6 checks passed
@yrong yrong deleted the ron/oak-30 branch October 18, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants