Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e environment and smoketests #1273

Merged
merged 16 commits into from
Aug 29, 2024
Merged

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Aug 23, 2024

All these fixes were made from clean build of nix environment and a clean checkout.

For some reason the polkadot-js-api does not obey the --nonce -1 flag anymore so I needed to remove it so that the testnet starts up correctly.

Tests Fixes:

  • register_token
  • send_token
  • transfer_token
  • set_price_params
  • set_token_transfer_fees
  • send_token_to_penpal

@@ -37,7 +37,7 @@
ps

# typescript
python3
python311
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required to build lodestar. Python version 3.12 deprecates some required packages.

@yrong
Copy link
Contributor

yrong commented Aug 23, 2024

For some reason the polkadot-js-api does not obey the --nonce -1 flag anymore so I needed to remove it so that the testnet starts up correctly.

@alistair-singh I can't reproduce the issue on my laptop with your branch, --nonce -1 does work and the testnet starts up as expected.

Btw: for local test I would suggest to use a short epoch length with Snowfork/polkadot-sdk#170 included and I made another PR in #1274 based on yours.

@alistair-singh
Copy link
Contributor Author

For some reason the polkadot-js-api does not obey the --nonce -1 flag anymore so I needed to remove it so that the testnet starts up correctly.

@alistair-singh I can't reproduce the issue on my laptop with your branch, --nonce -1 does work and the testnet starts up as expected.

Ok I will revert my changes to the nonce.

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@alistair-singh alistair-singh merged commit 3291185 into main Aug 29, 2024
@alistair-singh alistair-singh deleted the alistair/fix-smoketest branch August 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants