Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local setup #1131

Merged
merged 17 commits into from
Feb 8, 2024
Merged

Update local setup #1131

merged 17 commits into from
Feb 8, 2024

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Jan 30, 2024

Polkadot-sdk companion: Snowfork/polkadot-sdk#110
Resolves: SNO-826

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c4fe56) 49.66% compared to head (c99b047) 80.71%.
Report is 4 commits behind head on main.

❗ Current head c99b047 differs from pull request most recent head eb20a2b. Consider uploading reports for the commit eb20a2b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1131       +/-   ##
===========================================
+ Coverage   49.66%   80.71%   +31.04%     
===========================================
  Files          63       12       -51     
  Lines        3707      394     -3313     
  Branches       72       72               
===========================================
- Hits         1841      318     -1523     
+ Misses       1849       59     -1790     
  Partials       17       17               
Flag Coverage Δ
rust ∅ <ø> (∅)
solidity 80.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden marked this pull request as ready for review February 2, 2024 11:21
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines +5 to +15
echo "Checkout polkadot-sdk Snowfork fork"
pushd ..
if [ ! -d "polkadot-sdk" ]; then
git clone https://github.com/Snowfork/polkadot-sdk.git
fi
pushd polkadot-sdk
git checkout snowbridge
popd
popd

ln -sf ../polkadot-sdk polkadot-sdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this if we are still using the submodule?

Copy link
Contributor

@yrong yrong Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Clara removed the submodule, then we may also need to remove the entry in .gitmodules.

[submodule "polkadot-sdk"]
path = polkadot-sdk
url = https://github.com/Snowfork/polkadot-sdk.git

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 😄 6b4d745

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit a7f95fb into main Feb 8, 2024
2 checks passed
@claravanstaden claravanstaden deleted the local-dev-env branch February 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants