-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update local setup #1131
Update local setup #1131
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
===========================================
+ Coverage 49.66% 80.71% +31.04%
===========================================
Files 63 12 -51
Lines 3707 394 -3313
Branches 72 72
===========================================
- Hits 1841 318 -1523
+ Misses 1849 59 -1790
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
echo "Checkout polkadot-sdk Snowfork fork" | ||
pushd .. | ||
if [ ! -d "polkadot-sdk" ]; then | ||
git clone https://github.com/Snowfork/polkadot-sdk.git | ||
fi | ||
pushd polkadot-sdk | ||
git checkout snowbridge | ||
popd | ||
popd | ||
|
||
ln -sf ../polkadot-sdk polkadot-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this if we are still using the submodule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems Clara removed the submodule, then we may also need to remove the entry in .gitmodules.
Lines 1 to 3 in c1de208
[submodule "polkadot-sdk"] | |
path = polkadot-sdk | |
url = https://github.com/Snowfork/polkadot-sdk.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 😄 6b4d745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Polkadot-sdk companion: Snowfork/polkadot-sdk#110
Resolves: SNO-826
polkadot-sdk
and symlink it