Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all runtime tests to polkadot-sdk #1099

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Move all runtime tests to polkadot-sdk #1099

merged 5 commits into from
Jan 9, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jan 9, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a90f0c9) 80.57% compared to head (51a2eeb) 76.52%.

Files Patch % Lines
parachain/runtime/test-common/src/lib.rs 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   80.57%   76.52%   -4.06%     
==========================================
  Files          55       56       +1     
  Lines        2209     2326     +117     
  Branches       72       72              
==========================================
  Hits         1780     1780              
- Misses        412      529     +117     
  Partials       17       17
Flag Coverage Δ
rust 75.67% <0.00%> (-4.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong marked this pull request as ready for review January 9, 2024 08:18
claravanstaden
claravanstaden approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🏅

alistair-singh
alistair-singh approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

vgeddes
vgeddes reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree we should move the tests, but the support code for the tests should remain - see my full comment on slack: https://snowfork.slack.com/archives/G01BGMGLAC9/p1704789482331339?thread_ts=1704782841.923229&cid=G01BGMGLAC9

The support code in parachain/runtime/test_cases.rs should remain in our repo

@yrong yrong force-pushed the ron/snowbridge-runtime-tests branch 2 times, most recently from c0b3e1c to f6fd687 Compare January 9, 2024 12:47
vgeddes
vgeddes reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Just need to rename the crate.

parachain/runtime/tests/Cargo.toml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given its new purpose, we should rename this crate to snowbridge-runtime-test-common.

The directory should also be renamed accordingly: parachain/runtime/test-common

vgeddes
vgeddes approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit 2b3eead into main Jan 9, 2024
9 checks passed
@claravanstaden claravanstaden deleted the ron/snowbridge-runtime-tests branch January 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh approved these changes

@claravanstaden claravanstaden claravanstaden approved these changes

@vgeddes vgeddes vgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrong @vgeddes @claravanstaden @alistair-singh