Improve runtime tests #1001
Improve runtime tests #1001
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 81.14% 81.23% +0.09%
==========================================
Files 53 53
Lines 2132 2132
Branches 72 72
==========================================
+ Hits 1730 1732 +2
+ Misses 387 385 -2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@claravanstaden I've moved the tests in Snowfork/polkadot-sdk#17 to our own repo and made some fix. To seperate from cumulus it's more convenient to maintain/extend tests as required IMO. |
yrong
force-pushed
the
ron/runtime-tests
branch
from
c0b8ba5
to
4e1d39a
Compare
parachain/runtime-tests/Cargo.toml
Outdated
There was a problem hiding this comment.
Can we make this small change. Move this crate to directory parachain/runtime/tests/Cargo.toml.
Since @alistair-singh is also introducing a runtime-common crate, we should put all the runtime specific crates under parachain/runtime.
| --manifest-path polkadot-sdk/Cargo.toml | ||
| -p bridge-hub-rococo-integration-tests | ||
| -p bridge-hub-rococo-integration-tests snowbridge |
There was a problem hiding this comment.
What package is named snowbridge? I don't recall any package like that?
There was a problem hiding this comment.
Actually it's not a package name, the mod name to filter snowbrige tests only.
| @@ -12,6 +12,6 @@ members = [ | |||
| "pallets/ethereum-beacon-client", | |||
| "pallets/control", | |||
| "pallets/control/runtime-api", | |||
| "runtime/tests", | |||
There was a problem hiding this comment.
The tests crate is only used by the runtimes in polkadot-sdk/, so I don't think we should add it to the cargo workspace. We're effectively creating some kind of cyclical dependency loop here :)
Also because its going to bloat our local compile times.
When I run cargo test, I just want to run tests for our pallets and primitives crates. Not runtime-specific stuff.
So its fine for the crate to have its own Cargo.lock.
No description provided.