This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Audit-5: validate meta data of PNA #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrong
changed the title
| @@ -159,6 +159,12 @@ pub struct AssetMetadata { | |||
| pub decimals: u8, | |||
| } | |||
|
|
|||
| impl AssetMetadata { | |||
There was a problem hiding this comment.
Nonblocking: I would prefer to leave AssetMetadata as just plain old data and move this to the call site in the extrinsic. We do not re-use this validate method so its not needed. And I think we should add a test for the extrinsic to make sure the Error is raised in this case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://linear.app/snowfork/issue/SNO-1197