Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Audit 1, 7: Better Documentation #182

Open
wants to merge 3 commits into
base: audit-polkadot-stable2409
Choose a base branch
from
Open

Audit 1, 7: Better Documentation #182

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7053d1
better documenation about fee handling
alistair-singh Oct 16, 2024
dd5d8ee
PR feedback
alistair-singh Oct 20, 2024
8cc1390
more documentation
alistair-singh Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions bridges/snowbridge/primitives/router/src/outbound/mod.rs
View file
Open in desktop
alistair-singh marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,12 @@ where
ensure!(reserve_assets.len() == 1, TooManyAssets);
let reserve_asset = reserve_assets.get(0).ok_or(AssetResolutionFailed)?;

// If there was a fee specified verify it.
// Enough Fees are collected on Asset Hub, up front and directly from the user, to cover the
alistair-singh marked this conversation as resolved.
Show resolved Hide resolved
// complete cost of the transfer. Any additional fees provided in the XCM program are
// refunded to the beneficairy. We only validate the fee here if its provided to make sure
alistair-singh marked this conversation as resolved.
Show resolved Hide resolved
// the XCM program is well formed. Another way to think about this from an XCM perspective
// would be that the user offered to pay X amount in fees, but we charge 0 of that X amount
// (no fee) and refund X to the user.
if let Some(fee_asset) = fee_asset {
// The fee asset must be the same as the reserve asset.
if fee_asset.id != reserve_asset.id || fee_asset.fun > reserve_asset.fun {
Expand Down Expand Up @@ -374,7 +379,12 @@ where
ensure!(reserve_assets.len() == 1, TooManyAssets);
let reserve_asset = reserve_assets.get(0).ok_or(AssetResolutionFailed)?;

// If there was a fee specified verify it.
// Enough Fees are collected on Asset Hub, up front and directly from the user, to cover the
alistair-singh marked this conversation as resolved.
Show resolved Hide resolved
// complete cost of the transfer. Any additional fees provided in the XCM program are
// refunded to the beneficairy. We only validate the fee here if its provided to make sure
alistair-singh marked this conversation as resolved.
Show resolved Hide resolved
// the XCM program is well formed. Another way to think about this from an XCM perspective
// would be that the user offered to pay X amount in fees, but we charge 0 of that X amount
// (no fee) and refund X to the user.
if let Some(fee_asset) = fee_asset {
// The fee asset must be the same as the reserve asset.
if fee_asset.id != reserve_asset.id || fee_asset.fun > reserve_asset.fun {
Expand Down
Loading