Merge pull request #37 from TomzBench/fix-socket-iter #53
GitHub Actions / clippy
succeeded
Sep 22, 2023 in 0s
clippy
3 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 3 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.1 (d5c2e9c34 2023-09-13)
- cargo 1.72.1 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (d5c2e9c 2023-09-13)
Annotations
Check warning on line 242 in src/monitor.rs
github-actions / clippy
this `impl` can be derived
warning: this `impl` can be derived
--> src/monitor.rs:238:1
|
238 | / impl Default for EventType {
239 | | fn default() -> Self {
240 | | EventType::Unknown
241 | | }
242 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
218 + #[derive(Default)]
219 | pub enum EventType {
|
help: ...and mark the default variant
|
235 ~ #[default]
236 ~ Unknown,
|
Check warning on line 159 in src/monitor.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/monitor.rs:159:25
|
159 | SocketIter::new(&self)
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 268 in src/device.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/device.rs:268:18
|
268 | .map(|path| Path::new(path))
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Path::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Loading