Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported from_subsystem_sysname() #44

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Exported from_subsystem_sysname() #44

merged 2 commits into from
Sep 22, 2023

Conversation

rehar
Copy link

@rehar rehar commented Aug 27, 2023 •
edited
Loading

Exposed libudev's function udev_device_new_from_subsystem_sysname() .

Drakulix
Drakulix reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and sorry for missing this PR.

Would you mind adding a from_subsystem_sysname_with_context variant like the other constructors have?

Drakulix
Drakulix approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly did so myself. Thanks for working on this!

@Drakulix Drakulix merged commit 0ace976 into Smithay:master Sep 22, 2023
23 checks passed
@rehar
Copy link
Author

rehar commented Sep 22, 2023

Haha you beat me to it. Was about to start adding the context variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rehar @Drakulix