Fix drm::control::Device::add_planar_buffer when GBM Bo uses DrmModifier::Invalid #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One could argue that the |
Drakulix
approved these changes
Mar 20, 2024
tronical
force-pushed
the
simon/addfb2-no-modifiers
branch
from
8d8e61c
to
3f1c287
Compare
|
I force-pushed to get the formatting fixed (my bad). |
|
The CI failure looks bogus. The error about the invalid cast looks like it was from a build of an earlier sha. The latest build in https://github.com/Smithay/drm-rs/actions/runs/8346623741 has only the (seemingly unrelated) drm_syncobj failures. |
|
Could you rebase? #190 should have fixed CI. |
…ier::Invalid When adding a GBM supplied buffer via add_planar_buffer, since commit 6cb3a27 the modifiers are fetched directly from the planar buffer trait. What the code does not take into account though is when the GBM bo returns DrmModifier::Invalid. In that case add_fb2 expects 0 as modifier in the array for each plane, instead of DRM_FORMAT_MOD_INVALID.
tronical
force-pushed
the
simon/addfb2-no-modifiers
branch
from
4a092b0
to
c64dc35
Compare
|
Done :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a GBM supplied buffer via add_planar_buffer, since commit 6cb3a27 the modifiers are fetched directly from the planar buffer trait. What the code does not take into account though is when the GBM bo returns DrmModifier::Invalid. In that case add_fb2 expects 0 as modifier in the array for each plane, instead of DRM_FORMAT_MOD_INVALID.