move geometry reader inside the component (#2082)

Skyscanner · Oct 17, 2024 · bb036cb · bb036cb
1 parent 2968d95
commit bb036cb
Showing 1 changed file with 16 additions and 17 deletions.
diff --git a/Backpack-SwiftUI/ImageGallerySlideshow/Classes/BPKImageGallerySlideshow.swift b/Backpack-SwiftUI/ImageGallerySlideshow/Classes/BPKImageGallerySlideshow.swift
@@ -44,15 +44,15 @@ struct ImageGallerySlideshow<ImageView: View>: ViewModifier {
         @Binding var currentIndex: Int
 
         var body: some View {
-            GeometryReader { proxy in
-                VStack(spacing: .xl) {
-                    ImageGalleryHeader(
-                        closeAccessibilityLabel: closeAccessibilityLabel,
-                        onCloseTapped: onCloseTapped
-                    )
-                    .padding([.leading, .top], .base)
-                    
-                    ZStack(alignment: .bottom) {
+            VStack(spacing: .xl) {
+                ImageGalleryHeader(
+                    closeAccessibilityLabel: closeAccessibilityLabel,
+                    onCloseTapped: onCloseTapped
+                )
+                .padding([.leading, .top], .base)
+
+                ZStack(alignment: .bottom) {
+                    GeometryReader { proxy in
                         InternalCarouselWrapper(
                             images: images.map {
                                 $0.content()
@@ -62,16 +62,15 @@ struct ImageGallerySlideshow<ImageView: View>: ViewModifier {
                             currentIndex: $currentIndex
                         )
                         .frame(maxWidth: 400, maxHeight: 400)
-                        BPKBadge("\(currentIndex + 1)/\(images.count)")
-                            .badgeStyle(.strong)
-                            .padding(.bottom, 20)
                     }
-
-                    .accessibilityElement(children: .ignore)
-                    .accessibilityHidden(true)
-
-                    footer
+                    BPKBadge("\(currentIndex + 1)/\(images.count)")
+                        .badgeStyle(.strong)
+                        .padding(.bottom, 20)
                 }
+                .accessibilityElement(children: .ignore)
+                .accessibilityHidden(true)
+
+                footer
             }
             .background(Color(.canvasContrastColor))
         }