Add Ninemanga source #392

feserr · 2023-07-11T21:13:38Z

Checklist:

Updated source's version for individual source changes
Updated all sources' versions for template changes
Set appropriate nsfw value
Did not change id even if a source's name or language were changed
Tested the modifications by running it on the simulator or a test device

Closes #43
Closes #158

feserr · 2023-07-12T19:09:20Z

@Skittyblock Could you review it?

Skittyblock

add newlines at the end of jsons and use tabs instead of spaces for indentation
run cargo +nightly fmt
fix clippy warnings generated with cargo +nightly clippy

Skittyblock · 2023-07-13T02:34:20Z

src/rust/multi.ninemanga/res/settings.json

Why do you have this? You're not using it anywhere and there's only a single value

Copy and paste from another source 😅 . I will remove it

It's still here

Skittyblock · 2023-07-13T02:36:31Z

src/rust/multi.ninemanga/src/lib.rs

+	NineMangaSource {
+		base_url,
+		language,
+		completed_series: "Completed Series",


Why are you setting completed_series the same as the default?

Skittyblock · 2023-07-13T02:37:07Z

src/rust/multi.ninemanga/src/parser.rs

+				author: String::new(),
+				artist: String::new(),
+				description: String::new(),
+				url: String::new(),
+				categories: Vec::new(),
+				status: MangaStatus::Unknown,
+				nsfw: MangaContentRating::Safe,
+				viewer: MangaViewer::Default,


use ..Default::default()

Skittyblock · 2023-07-13T02:38:03Z

src/rust/multi.ninemanga/src/parser.rs

+			cover,
+			title,
+			author,
+			artist: String::new(),


..Default::Default()

Skittyblock · 2023-07-13T02:38:59Z

src/rust/multi.ninemanga/src/parser.rs

+			if nsfw_genres.contains(&category.clone().as_str()) {
+				nsfw = MangaContentRating::Nsfw;
+			}
+			if category.clone().as_str() == "Webtoon" {
+				viewer = MangaViewer::Scroll;
+			}
+			categories.push(category.clone());


I don't think you need to clone this string three times

Skittyblock · 2023-07-13T02:39:38Z

src/rust/multi.ninemanga/src/parser.rs

+		let status = status_from_string(html.select(".bookintro .red").first().text().read());
+		let mut categories = Vec::new();
+		let mut nsfw = MangaContentRating::Safe;
+		let mut viewer = MangaViewer::Default;


don't use Default (it's deprecated), use Rtl

Skittyblock · 2023-07-13T02:40:18Z

src/rust/multi.ninemanga/src/parser.rs

+				title: String::new(),
+				volume: -1.0,
+				chapter: chapter_number,
+				date_updated,
+				scanlator: String::new(),


..Default::default()

Skittyblock · 2023-07-13T02:42:12Z

src/rust/multi.ninemanga/src/parser.rs

+		for manga in html.select(".direlist dl").array() {
+			let manga_node = manga.as_node();
+			let title = manga_node.select("a.bookname").text().read();
+			let id = manga_node.select("a.bookname").attr("href").read();


Do not set a full url as a manga id. Use the path and prepend the base url when you actually need the full url. Using the url as an id is bad practice since it will break if the website changes domains.

Skittyblock · 2023-07-13T02:42:32Z

src/rust/multi.ninemanga/src/parser.rs

+					base64: String::new(),
+					text: String::new(),


..Default::default()

still not addressed

feserr · 2023-07-13T21:11:32Z

@Skittyblock I have update the branch addressing all your changes/comments. I tested and it is working Ok using the ID instead of the full URL.

Skittyblock · 2023-07-15T18:56:49Z

src/rust/multi.ninemanga/src/parser.rs

+			title,
+			author,
+			description,
+			url: id,


since you changed id, it shouldn't be an actual url

Skittyblock · 2023-07-15T18:57:04Z

src/rust/multi.ninemanga/.vscode/settings.json

don't include .vscode folder

I stagged unintentionally 😅

Skittyblock · 2023-07-15T18:57:43Z

src/rust/multi.ninemanga/src/parser.rs

+
+			chapters.push(Chapter {
+				id: chapter_id,
+				volume: -1.0,


remove the volume: -1.0 since it's include in the defaults

Suggested change

volume: -1.0,

Skittyblock · 2023-07-15T18:58:02Z

src/rust/multi.ninemanga/src/parser.rs

+					base64: String::new(),
+					text: String::new(),


still not addressed

Skittyblock · 2023-07-15T18:58:38Z

src/rust/multi.ninemanga/src/parser.rs

+
+	pub fn handle_url(&self, url: String) -> Result<DeepLink> {
+		Ok(DeepLink {
+			manga: Some(Self::parse_manga_details(self, url)?),


you changed id so it shouldn't be a url any longer, you need to parse the id out of it

still not addressed

Skittyblock · 2023-07-18T03:31:15Z

src/rust/multi.ninemanga/res/settings.json

this is still here

Sorry, I forgot to remove it.

Skittyblock · 2023-07-18T03:32:55Z

src/rust/multi.ninemanga/src/parser.rs

+				.read()
+				.replace(".html", "-10-1.html");
+
+			let url = chapter_id.clone();


chapter id should be the relative url, not the full url, just like manga ids

Skittyblock · 2023-07-23T19:51:35Z

src/rust/multi.ninemanga/src/helper.rs

+	pages
+}
+
+pub fn get_search_url(


for future reference, it's better to use QueryParameters from the aidoku-rs helpers crate

daarkdemon added 2 commits July 11, 2023 12:07

[template] Add support for ninemanga

f7c103a

Match source dir to cargo package

1e64bb6

Skittyblock requested changes Jul 13, 2023

View reviewed changes

feserr force-pushed the ninemanga branch from 3497df9 to fad8769 Compare July 13, 2023 21:10

Skittyblock requested changes Jul 15, 2023

View reviewed changes

feserr force-pushed the ninemanga branch 2 times, most recently from f7ce703 to 5988e6b Compare July 16, 2023 13:56

Skittyblock reviewed Jul 18, 2023

View reviewed changes

Create multi.ninemanga from ninemanga.

e58b1fe

feserr force-pushed the ninemanga branch from 5988e6b to e58b1fe Compare July 18, 2023 12:36

Skittyblock reviewed Jul 23, 2023

View reviewed changes

Skittyblock approved these changes Jul 23, 2023

View reviewed changes

Skittyblock merged commit 5717532 into Skittyblock:main Jul 23, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Ninemanga source #392

Add Ninemanga source #392

feserr commented Jul 11, 2023 •

edited by Skittyblock

Loading

feserr commented Jul 12, 2023

Skittyblock left a comment

Skittyblock Jul 13, 2023

feserr Jul 13, 2023

Skittyblock Jul 16, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 13, 2023

Skittyblock Jul 15, 2023

feserr commented Jul 13, 2023

Skittyblock Jul 15, 2023

Skittyblock Jul 15, 2023

feserr Jul 16, 2023

Skittyblock Jul 15, 2023

Skittyblock Jul 15, 2023

Skittyblock Jul 15, 2023

Skittyblock Jul 18, 2023

Skittyblock Jul 18, 2023

feserr Jul 18, 2023

Skittyblock Jul 18, 2023

feserr Jul 18, 2023

Skittyblock Jul 23, 2023

Add Ninemanga source #392

Add Ninemanga source #392

Conversation

feserr commented Jul 11, 2023 • edited by Skittyblock Loading

feserr commented Jul 12, 2023

Skittyblock left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feserr commented Jul 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feserr commented Jul 11, 2023 •

edited by Skittyblock

Loading