Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store#emit: if storage.emit throws an error, log it instead of hiding it #234

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Store#emit: if storage.emit throws an error, log it instead of hiding it #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,11 @@ define([
event.type = type;
try {
return this.storage.emit(type, event);
} finally {
}
catch (error) {
console.error(error);
}
finally {
// Return the initial value of event.cancelable because a listener error makes it impossible
// to know whether the event was actually canceled
return event.cancelable;
Expand Down