Prevents Spitter acid damage if the player controlling the Spitter enters spectator mode or switches teams before dying #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this plugin can be optimized and shouldn't be reliant on whether or not a player uses a spectate command 👀 |
altair-sossai
changed the title
jensewe
reviewed
Jan 17, 2025
| int type = GetEventInt(event, "type"); | ||
|
|
||
| // I don't know why 6144, but it works | ||
| if (type == 0 || type == 6144) |
There was a problem hiding this comment.
I think because we're generally preventing acid from spitter's suicide, this could be replaced with client == attacker which is more reliable.
jensewe
reviewed
Jan 17, 2025
|
|
||
| // I don't know why 6144, but it works | ||
| if (type == 0 || type == 6144) | ||
| g_bBlocked[client] = true; |
There was a problem hiding this comment.
Not something significant here but I feel like it would be better storing the game tick (or game time), in which way we don't need left4dhooks forwards for resets, as a single OnMapStart will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents an exploit where Spitter players switch to spectator mode before dying while positioned over survivors, causing double acid damage.