Skip to content

fix some more code issues #288

fix some more code issues

fix some more code issues #288

Triggered via push July 19, 2024 15:30
Status Success
Total duration 8m 0s
Artifacts 1

maven.yml

on: push
Matrix: build
Static Analysis
5m 15s
Static Analysis
Fit to window
Zoom out
Zoom in

Annotations

1 error, 160 warnings, and 38 notices
Test with Java 11
TypeError: Cannot read properties of undefined (reading 'group')
Test with Java 11
The following actions uses Node.js version which is deprecated and will be forced to run on node20: madrapps/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Redundant 'Collection.addAll()' call: barcode4j/src/main/java/org/krysalis/barcode4j/impl/ConfigurableBarcodeGenerator.java#L46
'addAll()' call can be replaced with parametrized constructor call
Constant values: barcode4j/src/main/java/org/krysalis/barcode4j/BarcodeUtil.java#L127
Condition `"Error instantiating a barcode generator: " + cl != null` is always `true`
Constant values: barcode4j/src/main/java/org/krysalis/barcode4j/tools/Length.java#L102
Condition `mode == 2` is always `true`
Nullability and data flow problems: barcode4j/src/main/java/org/krysalis/barcode4j/tools/ConfigurationUtil.java#L75
Argument `findDocumentElement((Document)node)` might be null
Deprecated API usage: barcode4j-xgc/src/main/java/org/krysalis/barcode4j/image/loader/PreloaderBarcode.java#L70
'closeQuietly(javax.xml.transform.Source)' is deprecated
Deprecated API usage: barcode4j-xgc/src/main/java/org/krysalis/barcode4j/image/loader/PreloaderBarcode.java#L83
'needInputStream(javax.xml.transform.Source)' is deprecated
Redundant type cast: barcode4j/src/main/java/org/krysalis/barcode4j/configuration/DefaultConfiguration.java#L93
Casting `this.m_attributes.keySet().toArray(...)` to `String[]` is redundant
Redundant type cast: barcode4j/src/main/java/org/krysalis/barcode4j/configuration/DefaultConfiguration.java#L238
Casting `this.m_attributes.put(...)` to `String` is redundant
Redundant type cast: barcode4j/src/main/java/org/krysalis/barcode4j/output/svg/SVGCanvasProvider.java#L180
Casting `doc.getDocumentElement()` to `Element` is redundant
Redundant type cast: barcode4j/src/main/java/org/krysalis/barcode4j/configuration/DefaultConfiguration.java#L103
Casting `this.m_attributes.get(...)` to `String` is redundant
Redundant type cast: barcode4j/src/main/java/org/krysalis/barcode4j/configuration/DefaultConfiguration.java#L98
Casting `this.m_children.toArray(...)` to `Configuration[]` is redundant
Simplifiable boolean expression: barcode4j/src/main/java/org/krysalis/barcode4j/impl/datamatrix/DataMatrixHighLevelEncoder.java#L384
`(lastCharSize <= 3 && available != 1) || lastCharSize > 3` can be simplified to 'lastCharSize \> 3\|\|available != 1'
Suspicious variable/parameter name combination: barcode4j/src/main/java/org/krysalis/barcode4j/impl/datamatrix/DataMatrixBean.java#L163
'moduleWidth' should probably not be returned from method 'getBarHeight'
Suspicious variable/parameter name combination: barcode4j/src/main/java/org/krysalis/barcode4j/impl/qr/QRCodeBean.java#L228
'moduleWidth' should probably not be returned from method 'getBarHeight'
Call to 'printStackTrace()': barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128AI.java#L136
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': barcode4j/src/main/java/org/krysalis/barcode4j/tools/DebugUtil.java#L56
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': barcode4j-fop-ext/src/main/java/org/krysalis/barcode4j/fop/BarcodeElement.java#L92
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': barcode4j-xalan/src/main/java/org/krysalis/barcode4j/xalan/BarcodeExt.java#L74
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': barcode4j-jdom/src/main/java/org/krysalis/barcode4j/output/svg/JDOMSVGCanvasProvider.java#L109
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': barcode4j-xalan/src/main/java/org/krysalis/barcode4j/xalan/BarcodeExt.java#L112
Call to `printStackTrace()` should probably be replaced with more robust logging
'Collection.toArray()' call style: barcode4j/src/main/java/org/krysalis/barcode4j/impl/ConfigurableBarcodeGenerator.java#L87
Call to `toArray()` with pre-sized array argument 'new String\[elements.size()\]'
'Collection.toArray()' call style: barcode4j/src/main/java/org/krysalis/barcode4j/impl/fourstate/AbstractRMCBCKIXLogicImpl.java#L95
Call to `toArray()` with pre-sized array argument 'new String\[codewords.size()\]'
'Collection.toArray()' call style: barcode4j-xalan/src/main/java/org/krysalis/barcode4j/xalan/ElemWrappingConfiguration.java#L105
Call to `toArray()` with pre-sized array argument 'new Configuration\[cfgList.size()\]'
Unchecked warning: barcode4j-xgc/src/main/java/org/krysalis/barcode4j/image/loader/PreloaderBarcode.java#L159
Unchecked call to 'put(K, V)' as a member of raw type 'java.util.Map'
Unchecked warning: barcode4j/src/main/java/org/krysalis/barcode4j/impl/upcean/UPCEANCanvasLogicHandler.java#L103
Unchecked call to 'push(E)' as a member of raw type 'java.util.Stack'
Unchecked warning: barcode4j/src/main/java/org/krysalis/barcode4j/DefaultBarcodeClassResolver.java#L136
Unchecked cast: 'java.lang.Class\>' to 'java.lang.Class'
Unchecked warning: barcode4j/src/main/java/org/krysalis/barcode4j/DefaultBarcodeClassResolver.java#L121
Unchecked cast: 'java.lang.Class\>' to 'java.lang.Class'
Unchecked warning: barcode4j-xgc/src/main/java/org/krysalis/barcode4j/image/loader/PreloaderBarcode.java#L157
Unchecked call to 'put(K, V)' as a member of raw type 'java.util.Map'
Unused import: barcode4j/src/main/java/org/krysalis/barcode4j/output/bitmap/ImageIOBitmapEncoder.java#L32
Unused import `import org.krysalis.barcode4j.tools.DebugUtil;`
Unnecessary 'return' statement: barcode4j/src/main/java/org/krysalis/barcode4j/impl/codabar/CodabarLogicImpl.java#L161
`return` is unnecessary as the last statement in a 'void' method
Unnecessary 'return' statement: barcode4j/src/main/java/org/krysalis/barcode4j/impl/codabar/CodabarLogicImpl.java#L163
`return` is unnecessary as the last statement in a 'void' method
Unnecessary unicode escape sequence: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128Bean.java#L36
Unicode escape sequence `\u00F0` can be replaced with 'ð'
Unnecessary unicode escape sequence: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128.java#L61
Unicode escape sequence `\u00f0` can be replaced with 'ð'
Unnecessary unicode escape sequence: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128.java#L66
Unicode escape sequence `\u00f1` can be replaced with 'ñ'
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128LogicImpl.java#L422
Variable `newTemplates` initializer `null` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/codabar/CodabarLogicImpl.java#L63
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/tools/VariableUtil.java#L32
Variable `end` initializer `0` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/int2of5/Interleaved2Of5LogicImpl.java#L41
Variable `displayChecksum` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128AI.java#L49
Variable `canDoChecksumADD` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/tools/IOUtil.java#L39
Variable `n` initializer `0` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code128/EAN128AI.java#L240
Variable `startLen` initializer `0` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code39/Code39LogicImpl.java#L89
Variable `extendedCharSet` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/upcean/UPCEANLogicImpl.java#L70
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/fourstate/AbstractFourStateLogicImpl.java#L31
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/postnet/POSTNETLogicImpl.java#L45
Variable `displayChecksum` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/datamatrix/DataMatrixHighLevelEncoder.java#L916
The value `findMinimums(charCounts, intCharCounts, min, mins)` assigned to `min` is never used
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code39/Code39LogicImpl.java#L88
Variable `displayChecksum` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/int2of5/Interleaved2Of5LogicImpl.java#L40
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code39/Code39LogicImpl.java#L87
Variable `displayStartStop` initializer `false` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/code39/Code39LogicImpl.java#L86
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/postnet/POSTNETLogicImpl.java#L44
Variable `checksumMode` initializer `ChecksumMode.CP_AUTO` is redundant
Unused assignment: barcode4j/src/main/java/org/krysalis/barcode4j/impl/datamatrix/DataMatrixHighLevelEncoder.java#L705
The value `context.symbolInfo.dataCapacity - context.getCodewordCount()` assigned to `available` is never used
Static Analysis
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Multiple occurrences of the same expression: barcode4j/src/main/java/org/krysalis/barcode4j/impl/pdf417/PDF417LogicImpl.java#L146
Multiple occurrences of `(30 * (y / 3)) + (errorCorrectionLevel * 3) + ((r - 1) % 3)`
Multiple occurrences of the same expression: barcode4j/src/main/java/org/krysalis/barcode4j/impl/pdf417/PDF417LogicImpl.java#L150
Multiple occurrences of `(30 * (y / 3)) + (errorCorrectionLevel * 3) + ((r - 1) % 3)`
Method can be extracted: barcode4j/src/main/java/org/krysalis/barcode4j/impl/upcean/UPCELogicImpl.java#L139
It's possible to extract method returning 'upcaFinished' from a long surrounding method
Method can be extracted: barcode4j/src/main/java/org/krysalis/barcode4j/impl/fourstate/USPSIntelligentMailBean.java#L116
It's possible to extract method returning 'barsPerInch' from a long surrounding method
Method can be extracted: barcode4j/src/main/java/org/krysalis/barcode4j/impl/fourstate/USPSIntelligentMailLogicImpl.java#L195
It's possible to extract method returning 'binary' from a long surrounding method
Method can be extracted: barcode4j/src/main/java/org/krysalis/barcode4j/output/java2d/Java2DCanvasProvider.java#L155
It's possible to extract method returning 'indent' from a long surrounding method

Artifacts

Produced during runtime
Name Size
jacoco.html Expired
1.44 KB