Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktops #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Desktops #107

wants to merge 4 commits into from

Conversation

Pspritechologist
Copy link
Member

Description

Adds a Desktop varient of just about every computer in the game, for making maps a little more spiffy!

Media

image

image

Changelog

🆑

  • add: Nanotrasen managed to find records of these odd things called 'Desktops...' They couldn't work out what any of them did, so they just put console boards in them!

@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review Someone please review this labels Apr 26, 2023
@github-actions
Copy link

github-actions bot commented Apr 26, 2023

RSI Diff Bot; head commit d9bf6b8 merging into 487554d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/SimpleStation14/Structures/Machines/computers_old.rsi

State Old New Status
accounts Added
ai-fixer Added
alert-0 Added
alert-1 Added
alert-2 Added
area_atmos Added
artifact Added
atmos_key Added
atmos_key_off Added
broken Added
cameras Added
civ_bounty Added
comm Added
comm_logs Added
comm_monitor Added
comm_syndie Added
command Added
computer Added
crew Added
dna Added
explosive Added
forensic Added
generic Added
generic_keyboard Added
generic_keys Added
holocontrol Added
id Added
id_key Added
id_key_off Added
laptop Added
laptop_key Added
laptop_key_off Added
library Added
mecha Added
mechpad Added
med_key Added
med_key_off Added
medcomp Added
medlaptop Added
mining Added
mining_key Added
mining_key_off Added
oldcomp Added
oldcomp_broken Added
power_key Added
power_key_off Added
power_monitor Added
rd_key Added
rd_key_off Added
rdcomp Added
recharge_comp Added
recharge_comp_on Added
request Added
robot Added
scannercomp Added
security Added
security_key Added
security_key_off Added
shuttle Added
slime_comp Added
solar_screen Added
stock_computer Added
supply Added
syndie_key Added
syndie_key_off Added
syndishuttle Added
tank Added
tcboss Added
tech_key Added
tech_key_off Added
teleport Added
teleport_key Added
teleport_key_off Added
telesci_key Added
telesci_key_off Added
tram Added

Edit: diff updated after d9bf6b8

@DEATHB4DEFEAT
Copy link
Member

so this is pretty much an optional resprite for consoles for mappers? would be cool if they were buildable

@Pspritechologist
Copy link
Member Author

Yep, that's the idea. Making them buildable would require an entire new base thing, like the computer or machine, and all the steps, plus a recipe for each one... 🙃

id: ComputerAlertDesktop
name: alerts computer
components:
- type: Fixtures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of redefining this on every prototype, use multiple parent types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parents are a bad idea, as then I'd also need to redirect the sprite names. Doing it this way is far less effort overall, as the change can be copied on mass and modified very easily, whereas sprite paths could not.

- TabletopMachineMask
layer:
- TabletopMachineLayer
- type: Sprite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with these

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as those :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minify the animation delays

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what if I like 400 line long files??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm okay then :trollface:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked in Discord for how to do it 😩

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh

@DEATHB4DEFEAT
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants