Additional test fixes #435
Conversation
The `SignalBase` method of the SignalBase class is never called;
probably it should have be the __init__ method. Remove it, since
`self.m_self` is always set on subclasses.
In `collect_and_report_only`, use `Exception`, instead of
`BaseException`, since the former does not catch `GeneratorExit`,
`KeyboardInterrupt` and `SystemExit`.
In `system_mode_can_record_and_report_binary`, the test fails as
expected, but the cause of the error is:
NameError: name 'time' is not defined
Import the `time` module.
Errors reported by `ruff check`.
Rename `Pie` to `pie`. I forgot to apply this change in d2403a7 (tests: use consistent naming convention in test cases).
Rename `python_coverage.runTestTest` to `python_coverage.runTest`.
Restore building of the sanitizer-coverage executable in CMake, and just skip the test if it was not built with clang. The original code made it hard to understand the purpose of the test.
cmake 3.12 supports the POSITION_INDEPENDENT_CODE property, so there is no need for the version check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 65.70% 65.68% -0.03%
==========================================
Files 58 58
Lines 4514 4514
Branches 4171 4171
==========================================
- Hits 2966 2965 -1
- Misses 1548 1549 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks, looks good! The sanitizer coverage collection is also not completely working, and is probably not very interesting anyway (since it still requires special compile options, which is sort of the point of kcov to start with). And kudos for the very good PR descriptions by the way! |
Yes, I was aware that the sanitizer is not working correctly. The problem is that the old test used
Thanks! |
tests: fix incorrect code in
test_compiled.pyThe
SignalBasemethod of theSignalBaseclass is never called; probably it should have be the__init__method. Remove it, sinceself.m_selfis always set on subclasses.In
collect_and_report_only, useException, instead ofBaseException, since the former does not catchGeneratorExit,KeyboardInterruptandSystemExit.In
system_mode_can_record_and_report_binary, the test fails as expected, but the cause of the error is:NameError: name 'time' is not defined
Import the
timemodule.Errors reported by
ruff check.tests: make naming convention consistent in
test_compiled.pyRename
Pietopie.I forgot to apply this change in d2403a7 (tests: use consistent naming convention in test cases).
tests: fix typo in
test_python.pyRename
python_coverage.runTestTesttopython_coverage.runTest.tests: fix
test_compiled.address_sanitizer_coveragetestRestore building of the
sanitizer-coverageexecutable in cmake, and just skip the test if it was not built with clang.The original code made it hard to understand the purpose of the test.
tests: remove obsolete code from
tests/CMakeListscmake 3.12 supports the
POSITION_INDEPENDENT_CODEproperty, so there is no need for the version check.NOTES
I'm not fully sure about commit "tests: fix test_compiled.address_sanitizer_coverage test".