fix: resource-provider server-api dependency #1824
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than a dev-dependency
|
I thougth server api was just typescript and not used in runtime at all. Why is it needed? |
v1.2.0 released to npmjs (dev-dependency), the plugin failed to load when the server starts citing unable to find sever-api references. The Freeboard-SK plugin also needs it as a dependency also, there clearly a runtime requirement created by tsc. |
|
I see some consts and a class now, not just types and interfaces. |
|
Changed the label to chore so that this does not get grouped under fixes in release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@signalk/server-apias a dependency rather than a dev-dependency.This fix is included as part of v1.2.1 release.