fix toc_controller bug in reader.js converting nav/ncx rel paths to o…

…pf rel
Sigil-Ebook · Jun 8, 2021 · 8cf514b · 8cf514b
1 parent ff466a6
commit 8cf514b
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 90 deletions.
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -1,3 +1,6 @@
+v030
+  - bug fix to correct Toc navigation error as it needs opf relative paths
+
 v020
   - added in plugin icons from BeckyEbook
 

diff --git a/epubjs_reader_bug_fixes.patch b/epubjs_reader_bug_fixes.patch
@@ -0,0 +1,22 @@
+--- reader/js/reader.js.orig	2021-06-08 09:45:16.000000000 -0400
++++ reader/js/reader.js	2021-06-08 09:51:48.000000000 -0400
+@@ -4310,7 +4310,11 @@
+
+ 	$list.append(docfrag);
+ 	$list.find(".toc_link").on("click", function(event){
+-			var url = this.getAttribute('href');
++            // convert href to be relative to the opf not ncx or nav
++            var ahref = this.getAttribute('href');
++            var basePath = book.packaging.navPath || book.packaging.ncxPath
++            var base = 'https://example.invalid/'
++            var url = new URL(ahref, base + basePath).href.replace(base, '')
+
+ 			event.preventDefault();
+
+@@ -4344,4 +4348,4 @@
+ 	};
+ };
+
+-//# sourceMappingURL=reader.js.map
+\ No newline at end of file
++//# sourceMappingURL=reader.js.map
diff --git a/plugin.xml b/plugin.xml
@@ -5,7 +5,7 @@
 <author>Sigil</author>
 <description>Provide a FuturePress EpubJS Reader to view the current epub being edited</description>
 <engine>python3.4</engine>
-<version>0.2.0</version>
+<version>0.3.0</version>
 <autostart>true</autostart>
 <autoclose>true</autoclose>
 <oslist>osx,win,unx</oslist>

diff --git a/reader/js/reader.js b/reader/js/reader.js
diff --git a/reader/js/reader.js.map b/reader/js/reader.js.map
diff --git a/reader/js/reader.min.js b/reader/js/reader.min.js
diff --git a/reader/js/reader.min.map b/reader/js/reader.min.map