Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up tests and run them on CI #382

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Fix up tests and run them on CI #382

merged 6 commits into from
Jan 17, 2025

Conversation

rwstauner
Copy link
Contributor

  • Upgrade minitest to fix dep on mutex_m
  • Skip over warnings when looking for error output
  • Use parens to remove warning
  • Fix class names for test that must never have worked
  • Use unfrozen string for buffer
  • Run tests on CI

@rwstauner rwstauner self-assigned this Jan 17, 2025
@rwstauner rwstauner force-pushed the rwstauner/tests branch 3 times, most recently from c50fb71 to fa85f7f Compare January 17, 2025 16:15
@maximecb maximecb merged commit 76cb917 into main Jan 17, 2025
2 checks passed
@maximecb maximecb deleted the rwstauner/tests branch January 17, 2025 16:32
@rwstauner rwstauner mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwstauner rwstauner

Labels
#gsd:39235
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwstauner @maximecb