Update paths and remove references to unnecessary dirs #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These look like great cleanups. |
k0kubun
approved these changes
Apr 22, 2024
yjit-metrics-pages/_includes/reports is a symlink to built-yjit-reports/_includes/reports so we can change to use it directly. The "_benchmarks/bench_*.md" files are now in built-yjit-reports. The "test_results" they reference are in raw-benchmark-data. yjit-metrics-pages/raw_benchmark_data is no longer being updated and this change removes references to it.
Get rid of one more reference to an unused dir.
Currently a symlink points from there to here. This code isn't currently used.
There is no reference to any jobs running these scripts. The comments are outdated and the `cd here and checkout and clean` command would effectively no-op since this dir doesn't get updated anymore.
This script chdir'ed to it but then only referenced files from other dirs.
rwstauner
force-pushed
the
rwstauner/dirs
branch
from
ddf877c to
370fa5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yjit-pages-metricsdir is a checkout of thepagesbranch of this repo which is no longer used.The subdirs with data are symlinks to other dirs on the server, so this updates the code to use those paths directly so we can eliminate this old dir.