add ES zip prefixes #50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cejaekl
reviewed
Dec 8, 2023
| @@ -27,38 +27,54 @@ zones: | |||
| code: C | |||
| tax: 0.0 | |||
| tax_name: VAT | |||
| postal_code_prefixes: | |||
There was a problem hiding this comment.
Suggested change
| postal_code_prefixes: | |
| zip_prefixes: |
cejaekl
reviewed
Dec 8, 2023
| - name: Málaga | ||
| code: MA | ||
| tax: 0.0 | ||
| tax_name: VAT | ||
| postal_code_prefixes: | ||
| - '29' | ||
| - name: Melilla |
There was a problem hiding this comment.
Melilla needs
zip_prefixes:
- '52'
cejaekl
reviewed
Dec 8, 2023
There was a problem hiding this comment.
This is a great start! 👏
It's going to need some refinement to cover edge cases.
For example, postcode 18312 Loja is used in both Las Rozuelas in Granada and Ventorros de Balerma in Córdoba, so we're going to need an entry:
zips_crossing_provinces:
`18312`:
- GR
- CO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
...
What approach did you choose and why?
...
What should reviewers focus on?
...
The impact of these changes
...
Testing
...
Checklist