Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preset block settings completion #732

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jan 23, 2025

What are you adding in this PR?

Fixes #623

  • Added support for presets blocks settings completion + hover
  • Should work for deep-nested blocks within presets

Testing

  • Checkout repo + branch + F5
  • In the test VScode window, open a theme with presets & blocks
  • Create a section/block that references a block
    • Add presets for the referenced block, and configure some of its settings (see tests / ticket description for more concrete examples)

example:

{% schema %}
{
  "name": "Example",
  "tag": null,
  "blocks": [{ "type": "@theme" }, { "type": "@app" }],
  "settings": [],
  "presets": [
    {
      "name": "Example Preset 1",
      "blocks": [
        {
          "type": "<referenced-block-name>",
          "settings": {
            "█"
          }
        }
      ]
    }
  ]
}
{% endschema %}

What's next? Any followup issues?

Pickup remaining tasks under #545

Before you deploy

  • I included a minor bump changeset
  • My feature is backward compatible

@aswamy aswamy requested a review from a team as a code owner January 23, 2025 23:12
@aswamy aswamy requested a review from charlespwd January 23, 2025 23:12
@aswamy aswamy force-pushed the feature/preset-block-settings-completion branch from 3d3ab01 to 1ca8046 Compare January 23, 2025 23:15
@aswamy aswamy force-pushed the feature/preset-block-settings-completion branch from 1ca8046 to e875edf Compare January 24, 2025 21:31
@aswamy aswamy force-pushed the feature/preset-block-settings-completion branch from e875edf to 820091c Compare January 24, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme block JSON preset block settings completion/hover support
1 participant