-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiquidDoc] Prevent rendering of hover tooltip for snippets with no renderable content #729
base: jm/param_hover
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6ad37f6
to
1f7a561
Compare
@charlespwd Branching off of this comment for snippets without a liquidDoc definition, what is some valuable content we can render here? Is there value in rendering the below? |
I mean... your opinion is as good as mine? Maybe would be better to add something that points to the snippet file in the description? Ideally we'd be able to differentiate between something that exists vs something that does not exist. But there's the theme check for that so 🤷 |
681ba72
to
52bf118
Compare
b32a5ff
to
16db3dd
Compare
What are you adding in this PR?
{% render 'snippet' %}
Prevents rendering hover tooltip for snippets that:
Renderable content: Currently, this means that it requires a
LiquidDoc
definition with@param
annotations, though this will soon expand to the description and@example
as wellBefore you deploy
changeset
allChecks
array insrc/checks/index.ts
yarn build
and committed the updated configuration filestheme-app-extension.yml
configchangeset
changeset