Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for global variables #2749

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

snutij
Copy link
Contributor

@snutij snutij commented Oct 21, 2024

Motivation

Iteration of #2644

Handle global variables in completion requests.

Implementation

  • Add $ as a new trigger_character (see this comment)
  • Add listener for all global variable nodes
  • Find in index with prefix
  • Push entries as CompletionItem in response_builder

Automated Tests

  • Added a test with assertions for each kind of global variable, and RBS completions.

Manual Tests

  • Write $ within a file, you should see completions coming from the RBS declaration.
  • Write $foo = 1, then bellow $f, you should see the completion.
Kapture.2024-10-21.at.23.31.16.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant