Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Customer resource #813

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add Customer resource #813

wants to merge 17 commits into from

Conversation

isamu
Copy link

@isamu isamu commented Mar 12, 2021

Customer resource was not available in this SDK, so I added customer resource. Please let me know if there are any tasks required for merging.

@isamu isamu changed the title [WIP] Add Customer resource Add Customer resource Mar 12, 2021
@E0han
Copy link

E0han commented Mar 29, 2021

Hey there, I'm looking to use this fork in my project, may I ask how to install your updated version of Shopify-buy?

@isamu
Copy link
Author

isamu commented Mar 29, 2021

Please use my build branch.

npm install  https://github.com/isamu/js-buy-sdk.git#customerResourceBuild

@isamu
Copy link
Author

isamu commented Mar 29, 2021

You may also need my type file for this package.
I push it https://github.com/isamu/js-buy-sdk/blob/customerResourceBuild/types/index.d.ts

@E0han
Copy link

E0han commented Mar 29, 2021

Please use my build branch.

npm install  https://github.com/isamu/js-buy-sdk.git#customerResourceBuild

Thanks for reply, I've tried this before, and it always give me git dep preparation failed error, may I ask is there anything need to install in advance?

@isamu
Copy link
Author

isamu commented Mar 29, 2021

I don't know the details about this issue, but if it's a dependency issue,
Please try to delete node_modules and package-lock.json and install again.

@E0han
Copy link

E0han commented Mar 29, 2021

I don't know the details about this issue, but if it's a dependency issue,
Please try to delete node_modules and package-lock.json and install again.

Aight, thanks for that

@E0han
Copy link

E0han commented Mar 29, 2021

Thanks @isamu in advance, I can't believe why Shopify-buy still doesn't have the feature for accessing CustomerResource. Hopefully this commit will be merged into the official repo asap.

For anyone who want this feature and facing git dep preparation failed error after npm install from the git repo. Just git clone it first, and install it as a local external module. Problem will be solved.

@isamu
Copy link
Author

isamu commented Mar 29, 2021

Thank you for your feedback.

I hope so too!! Thanks!

@krunalbad
Copy link

or you can just use this in pkg.json directly
"shopify-buy": "git+https://github.com/isamu/js-buy-sdk.git#customerResourceBuild",

@isamu isamu force-pushed the customerResource branch from 4a2000a to 26ba75a Compare July 3, 2021 02:09
@JeffJassky
Copy link

Will this get merged?

@nilaybrahmbhatt
Copy link

Why this branch is not merged till now?

@SHrebeniuk
Copy link

Nice, give it life!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants