-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No follow for Account Login header url #3611
Merged
jclarkin
merged 2 commits into
main
from
growth_labs/update_account_login_link_to_be_no_follow
Sep 18, 2024
Merged
No follow for Account Login header url #3611
jclarkin
merged 2 commits into
main
from
growth_labs/update_account_login_link_to_be_no_follow
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjn
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't 🎩 , but HTML changes are valid and accomplish the goal stated in the PR.
dan-menard
approved these changes
Sep 18, 2024
jclarkin
deleted the
growth_labs/update_account_login_link_to_be_no_follow
branch
September 18, 2024 19:59
dgopsq
added a commit
to unicomultiplo/dawn
that referenced
this pull request
Sep 20, 2024
* Update 2 translation files (Shopify#3602) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Release 15.1.0 (Shopify#3595) * Release notes + version bump * Fixed arrow in announcement bar and caret in product variant dropdown * Fixed announcement bar with multiple blocks * Adjustment to variant picker caret * Fixed multicolumn and mega menu * Updated release note * Fixed modals sticking around for Featured Product whens section is removed in the editor (Shopify#3609) * No follow for Account Login header url (Shopify#3611) * Update translations: merchant (Shopify#3612) * Update 1 translation file * Update 3 translation files * Update 1 translation file * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix workflows * Apply current custom theme * Update `theme_name` * Recent update * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo * Update from Shopify for theme dawn/main Committed from shop: Unico & Multiplo --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Tyler Alsbury <[email protected]> Co-authored-by: Jonathan Clarkin <[email protected]> Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
NikoBerger
pushed a commit
to NikoBerger/palmafits-dawn
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Added
nofollow
to account login anchor-links in header.Why are these changes introduced?
Shopify's merchant shop links currently lack a "nofollow" directive. Without this directive, Google may interpret these links as spammy backlinking.
More analysis details available here.
What approach did you take?
Implemented a "nofollow" directive on all merchant shop links pointing to shopify.com/account.
Visual impact on existing themes
None
Testing steps/scenarios
Demo links
Can be tested locally via:
Checklist
Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)