Skip to content

Commit

Permalink
[Sliders] Regression fix. Apply CSS only when necessary in theme edit…
Browse files Browse the repository at this point in the history
…or (#3070)

* [Sliders] Regretion fix. Apply CSS only when necessary in theme editor

* change of approach

* add comment to explain CSS
  • Loading branch information
ludoboludo authored Oct 19, 2023
1 parent d50698b commit 069c198
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 0 additions & 4 deletions assets/component-slider.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ slider-component.slider-component-full-width {
padding-bottom: 0;
}

.slider__slide[aria-hidden="true"] {
visibility: hidden;
}

@media screen and (max-width: 749px) {
.slider.slider--mobile {
position: relative;
Expand Down
6 changes: 6 additions & 0 deletions sections/announcement-bar.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@
</slideshow-component>
{%- if request.design_mode -%}
<script src="{{ 'theme-editor.js' | asset_url }}" defer="defer"></script>
<style>
/* theme editor power preview fix */
.announcement-bar-slider .slider__slide[aria-hidden='true'] {
visibility: hidden;
}
</style>
{%- endif -%}
{%- endif -%}
<div class="localization-wrapper">
Expand Down

0 comments on commit 069c198

Please sign in to comment.