Make load path cache work on TruffleRuby #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvdrum
changed the title
rwstauner
force-pushed
the
rwstauner/truffleruby-load-path-cache
branch
from
3cae6a7
to
d443e4e
Compare
rwstauner
force-pushed
the
rwstauner/truffleruby-load-path-cache
branch
2 times, most recently
from
66e3af0
to
f0889ee
Compare
rwstauner
force-pushed
the
rwstauner/truffleruby-load-path-cache
branch
2 times, most recently
from
bb77e60
to
d531d5a
Compare
rwstauner
force-pushed
the
rwstauner/truffleruby-load-path-cache
branch
from
e2eb363
to
ba6e82a
Compare
nirvdrum
reviewed
Jul 24, 2023
nirvdrum
reviewed
Jul 24, 2023
| assert_same path, internal_path | ||
|
|
||
| if truffleruby? | ||
| assert_equal path, internal_path |
There was a problem hiding this comment.
Is this comparison different from CRuby due to oracle/truffleruby#3138?
There was a problem hiding this comment.
no, i haven't filed an issue on truffleruby for it yet, but on CRuby $LOADED_FEATURES.last is the same (frozen) string object, but on TruffleRuby this is not the case (it's a different string object, not frozen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load Path Cache can work on the latest TruffleRuby (23.1.0 is due out in September) and offers a small speedup on an example project.
It does require an unreleased bug fix (oracle/truffleruby#3131)
so I added
truffleruby-headto CI to prove that it works on both the current and the next release.I used a string comparison on
RUBY_ENGINE_VERSION < "23.1.0"to do that checkwhich is consistent with other
RUBY_VERSION >= "2.7"style comparisons used in this repoand I think will work for the foreseeable future.
A few kernel tests are skipped due to oracle/truffleruby#3138.
A few test assertions had to be changed from "same" to "equal"
to account for TruffleRuby making copies of the strings that end up in
$LOADED_FEATURES.TruffleRuby also has a long string prefix on "builtin" features, so i added a bit of code to strip that off
so that the rest of the code is consistent. Does that make sense?