Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations and Code Refactoring #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wiktor-jozwiak
Copy link
Contributor

Pull Request: Optimizations and Code Refactoring

Description of Changes:

  1. BukkitConfigLoader:

    • Removed unnecessary this qualifications.
    • Applied consistent formatting.
  2. BukkitShopMCPlugin:

    • Improved handling of the configuration file.
    • Code optimization in the onEnable method.
    • Removed unnecessary null check when closing the socket.
    • Other minor improvements for code readability.
  3. BungeeConfigLoader:

    • Removed unnecessary this qualifications.
    • Applied consistent formatting.
  4. BungeeShopMCPlugin:

    • Improved handling of the configuration file.
    • Removed unnecessary null check when closing the socket.
    • Code optimization in the onEnable method.
    • Other minor improvements for code readability.
  5. BungeeResourceLoader:

    • Added IOException handling in the saveDefault method.
    • Applied consistent formatting.
  6. Config:

    • Removed direct this qualifications where not necessary.
    • Applied consistent formatting.
  7. ConfigLoader:

    • Added comments documenting methods.
  8. EmptyConfigFieldException:

    • Added a comment describing the class.
  9. ResourceLoader:

    • Applied consistent formatting.
    • Moved the creation of the data directory to a separate method.
    • Added IOException handling.
  10. ResourceLoaderException:

    • Applied consistent formatting.
  11. Socket:

    • Removed unnecessary Socket.this qualifications.
    • Applied consistent formatting.

# Conflicts:
#	bukkit/src/main/java/app/shopmc/plugin/bukkit/BukkitShopMCPlugin.java
#	bungee/src/main/java/app/shopmc/plugin/bungee/BungeeShopMCPlugin.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant