add gbdt transfer learning #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public MLData call() { | ||
| MLData result = tltm.compute(rawNsDataMap); | ||
| return result; |
There was a problem hiding this comment.
could you change to one line like 'return tltm.compute(rawNsDataMap);'
| for(FileStatus fst: modelFileStats) { | ||
| models.add(loadModel(modelConfig, fst.getPath(), fs, gbtConvertToProb, gbtScoreConvertStrategy)); | ||
| for(FileStatus f: modelFileStats) { | ||
| tmpModels.add(loadModel(modelConfig, f.getPath(), fs, gbtConvertToProb, gbtScoreConvertStrategy)); |
There was a problem hiding this comment.
better not use variable name like 'f'
| List<String> baseModelPaths = | ||
| (List<String>) modelConfig.getTrain().getParams().get(CommonConstants.GBDT_BASE_MODEL_PATHS); | ||
| if (!CollectionUtils.isEmpty(baseModelPaths)) { | ||
| // if there config base model in traning config, it means user want to eval transfer-learning model |
| */ | ||
| public static double[] merge(double[] a, double[] b) { | ||
| if (a == null || b == null || a.length != b.length) { | ||
| throw new RuntimeException("Input is invalid. a is " + Arrays.toString(a) + |
There was a problem hiding this comment.
IllegalArgumentException is better than RuntimeException.
Best practice should not use RuntimeException instread of a cutomized RuntimeException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.