Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an Image Attribute to trigger the image url generation instead of an interface #35

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

loevgaard
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (cec6f0d) to head (1bad35b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/DataMapper/ImageDataMapper.php 0.00% 11 Missing ⚠️
src/Document/Metadata/Metadata.php 25.00% 3 Missing ⚠️
src/Document/Attribute/Image.php 0.00% 1 Missing ⚠️
src/Document/Metadata/Image.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     31.86%   31.81%   -0.06%     
- Complexity      531      536       +5     
============================================
  Files           109      111       +2     
  Lines          1792     1798       +6     
============================================
+ Hits            571      572       +1     
- Misses         1221     1226       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit fd9b59d into master Oct 10, 2024
30 of 38 checks passed
@loevgaard loevgaard deleted the refactor-image-url branch October 10, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant