Fix event selection for daylight saving changes #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On days where daylight saving is toggled the day does not last exactly 86400000 ms. In the timezone Europe/Berlin for example daylight saving time was toggled on 2022-03-27 at 02:00 hours. This results in 2022-03-27T00:00:00 + 86400000 ms = 2022-03-28T01:00:00. Therefore events where displayed on the wrong day.
|
@Serhioromano thank you for merging. Do you mind tagging a release? The last one is quite old and having a recent release could help new people coming to the repository to not ask #778 again. Also it would help me to bundle the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On days where daylight saving is toggled the day does not last exactly
86400000 ms. In the timezone Europe/Berlin for example daylight saving
time was toggled on 2022-03-27 at 02:00 hours. This results in
2022-03-27T00:00:00 + 86400000 ms = 2022-03-28T01:00:00. Therefore
events where displayed on the wrong day.