Fix deprecated class Hooks replaced by HookContainer #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,8 +34,15 @@ public function __construct( Store $store, Options $options ) { | |||
| * @since 1.0 | |||
| */ | |||
| public function register() { | |||
| foreach ( $this->handlers as $name => $callback ) { | |||
| Hooks::register( $name, $callback ); | |||
| if ( class_exists( 'MediaWiki\HookContainer\HookContainer' ) ) { | |||
There was a problem hiding this comment.
Using HookContainer::class is better. This works even if the class does not exist.
There was a problem hiding this comment.
If the check needed at all? I see HookContainer was added in MW 35
There was a problem hiding this comment.
If the check needed at all? I see HookContainer was added in MW 35
No it is not needed.
|
This was done in 4e180f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding this commit, I kept the compatibility with MW 1.31, else without the compatibility part the extension should be marked MW 1.35+.
Fixes #75
This PR includes: