SkinTemplateOutputPageBeforeExec hook is being deprecated #69 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible solution for: SkinTemplateOutputPageBeforeExec hook is being deprecated SemanticMediaWiki#69.
Possible solution for: SkinTemplateOutputPageBeforeExec hook is being deprecated SemanticMediaWiki#69.
|
@UnknownSkyrimPasserby thanks for your PR. At the moment, Travis CI is broken. This should be fixed first before merging. See SemanticMediaWiki/SemanticMediaWiki@76a668c how Travis CI can be fixed. Would you give it a try fixing it? Finally, you shoud see "green" for Travis CI instead of failed:
Also the Travis test matrix could be updated to more recent versions. See https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/cb6c94785d32f19bc1c192744a1be73fe63f729e/.travis.yml#L16 to get an idea. |
|
@UnknownSkyrimPasserby also keep in mind, that any changes should not break compatibility. All supported MW versions needs to work after your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I created a possible solution for issue #69. Unfortunately I have no skills in php, I have no idea how MW or SMW works (under hood) and my only experience in this field is this patch: D Feel free to modify it and adapt it to your knowledge.
Disclaimer: I only added new code, didn't clean old one, it's still there.
Greetings