-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Form.Group): add disabled prop #4436
feat(Form.Group): add disabled prop #4436
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4436 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 186 186
Lines 3511 3511
=======================================
Hits 3494 3494
Misses 17 17
☔ View full report in Codecov by Sentry. |
Could anyone help with why the Vercel deployment is failing? |
https://vercel.com/semantic-ui/semantic-ui-react/2rsf2GtY7HLtJkrukYAvzAAMpkEz https://vercel.com/semantic-ui/semantic-ui-react/FjCWFAo6wewW72a5e2QHf3jL8wCA Going through the logs of these deployments indicates that bumping the node version from 14 to 18 has been long due. The build logs clearly say that builds after 15 Aug 2023 will fail. |
@naman1608 @VaibhavMalik4187 thanks for heads up. I changed Node version in settings, all good now 🟢 I also added a test, so we are good to merge 🎉 |
Fixes #4435