Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form.Group): add disabled prop #4436

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

naman1608
Copy link
Contributor

Fixes #4435

@welcome
Copy link

welcome bot commented Sep 1, 2023

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d3e162) 99.51% compared to head (bb8d39d) 99.51%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4436   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         186      186           
  Lines        3511     3511           
=======================================
  Hits         3494     3494           
  Misses         17       17           
Files Changed Coverage Δ
src/collections/Form/FormGroup.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naman1608
Copy link
Contributor Author

Could anyone help with why the Vercel deployment is failing?

@VaibhavMalik4187
Copy link

Could anyone help with why the Vercel deployment is failing?

https://vercel.com/semantic-ui/semantic-ui-react/2rsf2GtY7HLtJkrukYAvzAAMpkEz

https://vercel.com/semantic-ui/semantic-ui-react/FjCWFAo6wewW72a5e2QHf3jL8wCA

Going through the logs of these deployments indicates that bumping the node version from 14 to 18 has been long due. The build logs clearly say that builds after 15 Aug 2023 will fail.

@layershifter
Copy link
Member

@naman1608 @VaibhavMalik4187 thanks for heads up. I changed Node version in settings, all good now 🟢 I also added a test, so we are good to merge 🎉

@layershifter layershifter enabled auto-merge (squash) September 4, 2023 12:28
@layershifter layershifter changed the title fix(Form.Group): add disabled flag feat(Form.Group): add disabled prop Sep 4, 2023
@layershifter layershifter merged commit 79ffb36 into Semantic-Org:master Sep 4, 2023
4 checks passed
@welcome
Copy link

welcome bot commented Sep 4, 2023

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.Group is not accepting disabled flag
3 participants