Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports for list-of-table options #12363

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

sbabcoc
Copy link
Contributor

@sbabcoc sbabcoc commented Jul 13, 2023

Currently our json based configurations does not
support List of Maps (this is supported on Toml
format)

Issue details are available in
https://groups.google.com/g/selenium-developers/c/_UYMd3ZjQ0M

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

More details on this issue is available in https://groups.google.com/g/selenium-developers/c/_UYMd3ZjQ0M

Motivation and Context

To support list of maps when dealing with json config files for Grid.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbabcoc sbabcoc force-pushed the pr/add-list-of-array-support branch from 314bbb3 to 26e68f1 Compare July 13, 2023 19:02
@sbabcoc sbabcoc force-pushed the pr/add-list-of-array-support branch from 26e68f1 to 3c9a566 Compare July 13, 2023 21:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (276240d) 57.28% compared to head (b7ab184) 57.28%.

❗ Current head b7ab184 differs from pull request most recent head 1c2aac1. Consider uploading reports for the commit 1c2aac1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12363   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5333     5333           
  Branches      193      193           
=======================================
  Hits         3055     3055           
  Misses       2085     2085           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbabcoc sbabcoc force-pushed the pr/add-list-of-array-support branch from 3c9a566 to d233db6 Compare July 14, 2023 21:25
.bazelignore Outdated Show resolved Hide resolved
@sbabcoc sbabcoc force-pushed the pr/add-list-of-array-support branch from d233db6 to b380ed2 Compare July 16, 2023 01:55
@sbabcoc sbabcoc force-pushed the pr/add-list-of-array-support branch from b380ed2 to 1c2aac1 Compare July 16, 2023 17:32
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(Test failure is unrelated to this change).

@diemol diemol merged commit 3bebd42 into SeleniumHQ:trunk Jul 16, 2023
50 of 51 checks passed
@sbabcoc sbabcoc deleted the pr/add-list-of-array-support branch July 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants