resize more aggressively + driver stabilization

SeleniumHQ · Jan 26, 2024 · 6477adf · 6477adf
1 parent 100f4c8
commit 6477adf
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/packages/selenium-ide/package.json b/packages/selenium-ide/package.json
@@ -1,6 +1,6 @@
 {
   "name": "selenium-ide",
-  "version": "4.0.1-alpha.80",
+  "version": "4.0.1-alpha.81",
   "private": false,
   "description": "Selenium IDE electron app",
   "author": "Todd <[email protected]>",
@@ -116,7 +116,7 @@
     "@seleniumhq/side-api": "^4.0.0-alpha.45",
     "@seleniumhq/side-commons": "^4.0.0-alpha.2",
     "@seleniumhq/side-model": "^4.0.0-alpha.5",
-    "@seleniumhq/side-runtime": "^4.0.0-alpha.35",
+    "@seleniumhq/side-runtime": "^4.0.0-alpha.36",
     "dnd-core": "^16.0.1",
     "electron-chromedriver": "^28.0.0",
     "electron-log": "^5.0.1",

diff --git a/packages/selenium-ide/src/main/session/controllers/Windows/index.ts b/packages/selenium-ide/src/main/session/controllers/Windows/index.ts
@@ -453,7 +453,9 @@ export default class WindowsController extends BaseController {
       this.session.store.set(sizeKey as any, size)
     }
     window.on('move', recalculateEverything)
+    window.on('moved', recalculateEverything)
     window.on('resize', recalculateEverything)
+    window.on('resized', recalculateEverything)
   }
 
   async onProjectLoaded() {

diff --git a/packages/side-runner/package.json b/packages/side-runner/package.json
@@ -24,7 +24,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@seleniumhq/side-model": "^4.0.0-alpha.5",
-    "@seleniumhq/side-runtime": "^4.0.0-alpha.35",
+    "@seleniumhq/side-runtime": "^4.0.0-alpha.36",
     "commander": "^11.0.0",
     "glob": "^10.3.1",
     "jest": "^29.6.0",

diff --git a/packages/side-runtime/package.json b/packages/side-runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/side-runtime",
-  "version": "4.0.0-alpha.35",
+  "version": "4.0.0-alpha.36",
   "private": false,
   "description": "Selenium IDE playback and execution",
   "author": "Tomer <[email protected]>",

diff --git a/packages/side-runtime/src/webdriver.ts b/packages/side-runtime/src/webdriver.ts
@@ -1474,10 +1474,14 @@ export default class WebDriverExecutor {
     const visibleCondition = new WebElementCondition(
       'for element to be visible',
       this.withCancel(async () => {
-        const el = await this.elementIsLocated(locator, ...fallbacks)
-        if (!el) return null
-        if (!(await el.isDisplayed())) return null
-        return el
+        try {
+          const el = await this.elementIsLocated(locator, ...fallbacks)
+          if (!el) return null
+          if (!(await el.isDisplayed())) return null
+          return el
+        } catch (e) {
+          return null
+        }
       })
     )
     return await this.driver.wait<WebElementShape>(visibleCondition, timeout)