Skip to content

Commit

Permalink
fix binary release pathing
Browse files Browse the repository at this point in the history
  • Loading branch information
toddtarsi committed Dec 27, 2023
1 parent b01ceb6 commit 59229ca
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/selenium-ide/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "selenium-ide",
"version": "4.0.1-alpha.68",
"version": "4.0.1-alpha.69",
"private": false,
"description": "Selenium IDE electron app",
"author": "Todd <[email protected]>",
Expand Down
26 changes: 19 additions & 7 deletions packages/selenium-ide/src/main/session/controllers/Driver/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,25 @@ export const port = app.isPackaged ? 9516 : 9515
* 4. When Electron is quitting, close the child driver process
*/

const ourElectronPath = __non_webpack_require__.resolve(
path.join(
'electron-chromedriver',
'bin',
'chromedriver' + (os.platform() === 'win32' ? '.exe' : '')
)
)
const electronBinary = `chromedriver${os.platform() === 'win32' ? '.exe' : ''}`
const ourElectronPath = app.isPackaged
? path.resolve(
path.join(
__dirname,
'..',
'node_modules',
'electron-chromedriver',
'bin',
electronBinary
)
)
: __non_webpack_require__.resolve(
path.join(
'electron-chromedriver',
'bin',
electronBinary
)
)

const getDriver = ({ browser, version }: BrowserInfo) =>
(browser === 'electron'
Expand Down

0 comments on commit 59229ca

Please sign in to comment.