Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code fix in import_actions_utils.py #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor code fix in import_actions_utils.py #43

wants to merge 1 commit into from

Conversation

mmulchandani
Copy link

action["client_userid"] = f["item_id"] changed to => action["client_userid"] = f["user_id"]
action["client_itemid"] = f["user_id"] changed to => action["client_itemid"] = f["item_id"]

It is a minor error and doesn't seem to impact the output, since the model build doesn't seem to be using the client_userid and client_itemid fields. I did verify the first few lines of the actions.json file generated after the fix and it looked correct.

I ran the ml100k example and the recommendations generated after the fix were similar to those before the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant