Topic landing pools sql #2110
Topic landing pools sql #2110
Conversation
…represent many to many relationship
| @@ -0,0 +1,99 @@ | |||
| from django.contrib import admin, messages | |||
| from django_topics.models import Topic, TopicPool | |||
| from django_topics.models.pool import PoolType | |||
There was a problem hiding this comment.
You can import PoolType directly fromdjango_topics.models since you've already imported it there from the sub-file
|
|
||
| def delete_all_data(): | ||
| print("Delete data") | ||
| Topic.pools.through.objects.all().delete() |
There was a problem hiding this comment.
The explicit deletion of the through model records is not strictly needed.
On intermediate through models in a m2m relationship, the default behavior when deleting either of the related models is to delete the associated records in the through model as well (the on_delete parameter of the ForeignKey defaults to CASCADE)
Your call if it's clearer to keep it in or not.
| @@ -50,7 +50,7 @@ class Header extends Component { | |||
| { Sefaria._siteSettings.TORAH_SPECIFIC ? | |||
| <a className="home" href="/" >{logo}</a> : null } | |||
| <a href="/texts" className="textLink"><InterfaceText context="Header">Texts</InterfaceText></a> | |||
| <a href="/topics" className="textLink"><InterfaceText>Topics</InterfaceText></a> | |||
| <a href="/django_topics" className="textLink"><InterfaceText>Topics</InterfaceText></a> | |||
There was a problem hiding this comment.
I think this (and all the diffs below changing /topics to /django_topics) might be a mistake... It doesn't seem like we set any route for this URL.
Maybe an errant find/replace?
Description
Introduces the
TopicPoolLinkmodel, the first time we're using Django models in the system.poolandtopic_slugfields.PoolTypeEnum for defining pool types (TEXTUAL,SHEETS,PROMOTED).admin_toolsinINSTALLED_APPS.Also refactors
get_random_topicand related functions to utilizeTopicPoolLink, as a proof-of-concept for TopicPoolLink IRL.