Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] "Build" workflow fails to compile SeedSigner OS #672

Closed
wants to merge 1 commit into from

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jan 23, 2025

Description

The build.yml workflow has been broken since sometime between Dec 23rd and Jan 12th.

My attempts to resolve it keep failing. The error displayed in the workflow runs is wrong; it can't find the *.img file because the Buildroot compilation never succeeded.

I have not been able to see anything that might explain the failure in the compiler output.

And there were no SeedSigner OS changes in that time frame that would affect compilation.

Keeping this PR as a DRAFT since I don't have an actual solution yet.


Note: Ignore the failing CI / test workflows on this PR; those are addressed in #671.


This pull request is categorized as a:

  • Bug fix

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

  • N/A

@kdmukai
Copy link
Contributor Author

kdmukai commented Jan 23, 2025

@dbast any ideas? It seems like something in the Actions backend must have changed? Or some dependency in Buildroot / SeedSigner OS isn't version pinned?

@dbast
Copy link
Contributor

dbast commented Jan 23, 2025

@kdmukai the build.sh does not stop on error, the script would need a set -o pipefail -o errexit right at the beginning... from the current build log it is unclear if the final build failure is a result of a previous masked/non-visible error... errexit forces bash to immediately exit on any error, so it becomes easier to spot what is the problem ... trying that in #673 by setting those options from the outside

@dbast
Copy link
Contributor

dbast commented Jan 23, 2025

no masked error... the tooling on the action runners seem to have changed... switching to build inside Docker is maybe better... trying that

@kdmukai
Copy link
Contributor Author

kdmukai commented Jan 27, 2025

Closing. Fixed in #673.

@kdmukai kdmukai closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants