Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet connect upgrade #159

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Wallet connect upgrade #159

merged 2 commits into from
Oct 15, 2024

Conversation

Plopmenz
Copy link
Collaborator

Type of change

Bug fix / New feature

Does it contain breaking changes?

No

Description

Upgrading the wallet connect stack to the latest version. Converting hooks and their return types to the new variants.

Changes

  • Update to AppKit (instead of legacy web3modal)
  • Update hooks to new wagmi version
  • Use viem for contract interactions outside of the Diamond Governance SDK
  • Convert most ethers types to the viem variants (TransactionReceipt, bigint, etc.)

Copy link
Contributor

@slingerbv slingerbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, so... Many... Updates!

@slingerbv slingerbv merged commit 1af1526 into dev Oct 15, 2024
3 of 5 checks passed
@Plopmenz Plopmenz deleted the wallet-connect-upgrade branch October 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants