yakui-wgpu: add mipmap filtering for custom textures #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could also be nice to simply pass one's own sampler |
LPGhatguy
reviewed
Jan 25, 2024
Comment on lines
+37
to
+44
| (Nearest, Nearest, Nearest) => &self.nearest_nearest_nearest, | ||
| (Linear, Linear, Nearest) => &self.linear_linear_nearest, | ||
| (Nearest, Linear, Nearest) => &self.nearest_linear_nearest, | ||
| (Linear, Nearest, Nearest) => &self.linear_nearest_nearest, | ||
| (Nearest, Nearest, Linear) => &self.nearest_nearest_linear, | ||
| (Linear, Linear, Linear) => &self.linear_linear_linear, | ||
| (Nearest, Linear, Linear) => &self.nearest_linear_linear, | ||
| (Linear, Nearest, Linear) => &self.linear_nearest_linear, |
There was a problem hiding this comment.
This code is very straightforward (and I'm so happy that Rust verifies this for us!) but... man, the combinatorics here are rough. 😅
There was a problem hiding this comment.
Agreed! I chose to follow the original code but this is clearly the limit
LPGhatguy
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Straightforward enough fix, LGTM!
I think you're right that it'd be nice for users to be able to provide their own samplers. If we have any other sampler fields that we want to configure (address mode?) it would probably justify that feature so that we don't end up with another axis of combinations in this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can provide custom textures that have been properly mipmapped.
So we allow nice trilinear filtering