Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CountGrid #132

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Implement CountGrid #132

merged 2 commits into from
Dec 23, 2023

Conversation

Uriopass
Copy link
Contributor

@Uriopass Uriopass commented Dec 20, 2023

Implement a grid based on a given number of cross-axis row/columns and usual List parameters (cross/main axis alignment, main size..)

Note that there's a lot of tricky questions around what to do if the constraint min is bigger than the cell sizes. I have copied the list behavior which is to not do anything about it for the cell layout.

The provided example allows testing the different behaviors. I'm guessing it'll have to be iterated on upon usage but it should be a not-so-bad foundation.

2023-12-20_21-55-55.mp4

Implement a grid based on a given number of cross-axis row/columns and
usual List parameters (cross/main axis alignment, main size..)
@Uriopass Uriopass requested a review from LPGhatguy as a code owner December 20, 2023 20:51
Using center or align within cells means that it must take the max
space allocated when you just want to center the elements
Copy link
Member

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I didn't do a super careful review, but let's get this in and see how it works for folks in practice.

@LPGhatguy LPGhatguy merged commit bec5188 into SecondHalfGames:main Dec 23, 2023
2 checks passed
@Uriopass Uriopass deleted the count_grid branch December 23, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants