Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata related patches #12

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Appdata related patches #12

merged 2 commits into from
Sep 27, 2024

Conversation

yakushabb
Copy link
Contributor

@yakushabb yakushabb commented Apr 1, 2024

appdata: Add branding colors

appdata: Update screenshot

  • Fix screenshot URL
  • Add a caption

appdata: translate=no properties

It appears that the appstream project no longer supports
translatable=no properties, and gettext extract the
translatable=no marked strings as translatable.

I opened an issue to inform about the situation, but translatable=no
properties are not accepted by developers. You can find the issue
here: https://github.com/ximion/appstream/issues/623

Please test your script or string extraction process before merging this PR.

In MetaInfo files, each individual paragraph of a description
(or enumerated entry) is translated individually, however,
you can only exclude the complete block from being translated
by adding translate="no" to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html

@yakushabb yakushabb changed the title Fixtr Appdata related patches Apr 1, 2024
@yakushabb
Copy link
Contributor Author

Also Fixes: #9

@SeaDve
Copy link
Owner

SeaDve commented Apr 3, 2024

Thanks, I appreciate the helps, as always! But, like the other apps, ninja -C _build kooha-pot seems to ignore it. You could create a separate PR, so I could merge the other commits.

@SeaDve
Copy link
Owner

SeaDve commented Sep 26, 2024

Hi, thanks for the PR. However, may I request a rebase, thanks!

@SeaDve
Copy link
Owner

SeaDve commented Sep 27, 2024

Thanks!

@SeaDve SeaDve merged commit 4c661ac into SeaDve:main Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants