Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an easier message to read when errors occur. #20

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

perrygoy
Copy link
Member

Playwright has very verbose error messages. Which is nice! But we did all this work to make Target have a nice readable name, only to spit out the complicated Playwright locator while looking at the error log? No thanks.

This PR wraps all the Actions in a try/except which will show a helpful DeliveryError if Playwright encounters an error.

@perrygoy perrygoy merged commit bb01d34 into trunk Jul 16, 2024
23 checks passed
@perrygoy perrygoy deleted the wrap-playwright-errors branch July 16, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant