Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While i was writing a test that has two Actors attempt to get on a call together, i noticed only one of the Actors was successfully tearing down and taking screenshots. The second Actor would get an error from Playwright, saying that the Playwright instance was already closed.
Well of course it was, that first Actor would do
self.playwright.close()
when theirBrowseTheWebSynchronously
ability was forgotten!This PR takes out that call. Now that i'm more familiar with how Playwright works, keeping the Playwright instance active makes a lot more sense, especially in the context of the
pytest
fixtures Playwright provides in their plugin.