#88: Enable q through z. #117
Conversation
| except self.ignore_exceptions: | ||
| if not settings.UNABRIDGED_NARRATION: | ||
| the_narrator.clear_backup() | ||
| else: |
There was a problem hiding this comment.
It was the recommendation of one of these... Tryceratops, i think?
The intention is to make it clear what bits you expect to raise an exception and what bits you want to run if the exception was not raised.
| @@ -31,7 +31,7 @@ def function_should_log_none(func: Function) -> bool: | |||
| return False | |||
|
|
|||
|
|
|||
| def act(title: str, gravitas: Optional[str] = None) -> Callable[[Function], Function]: | |||
| def act(title: str, gravitas: str | None = None) -> Callable[[Function], Function]: | |||
There was a problem hiding this comment.
What are your thoughts on a type alias for the returns?
T_func = Callable[[Function], Function]
There was a problem hiding this comment.
It might be a good idea, what do you think about calling it something thematic?
Narrative = Callable[[Function], Function] # ?
Tale = Callable[[Function], Function] # ?
Yarn = Callable[[Function], Function] # ?
...
| exec(f.read(), about) | ||
|
|
||
| with open("README.md", "r") as f: | ||
| with open("README.md") as f: |
There was a problem hiding this comment.
We really ought to commit to pulling the setup.py from all the projects.
There was a problem hiding this comment.
Let's do it with this release and see how it goes, eh?
| @@ -38,12 +38,11 @@ def test__indent(self) -> None: | |||
|
|
|||
| def test_step(self, caplog) -> None: | |||
| manager = StdOutManager() | |||
| test_message = "Wow. I’m Mr. Manager." | |||
| test_message = "Wow. I'm Mr. Manager." | |||
There was a problem hiding this comment.
I noticed this one too. I'm really curious how the other character ended up there?
Is that a windows/mac thing?
There was a problem hiding this comment.
Mac, by default, will put the smartquotes in, especially on copy/paste. I must have either copied the quote from a site that had the smartquote there or had written it in here before i angrily turned off the setting that makes smartquotes everywhere. 😩
| @@ -108,7 +108,7 @@ def test_deep_kink(self) -> None: | |||
| mock_adapter = get_mock_adapter() | |||
| narrator = Narrator(adapters=[mock_adapter]) | |||
|
|
|||
| with narrator.mic_cable_kinked(): | |||
| with narrator.mic_cable_kinked(): # noqa: SIM117 | |||
There was a problem hiding this comment.
WUT!?! you didn't want to make it look terrible? 😁
There was a problem hiding this comment.
Hahaha i tried it the way it suggested and... yeah. Sometimes i think we know better.
This enables the final bits! I'm saving
flake8-annotationsfor its own PR as i mess around withmypysettings to getmypyto complain about the same things, but in a more sensible way.