Skip to content

Commit

Permalink
#88: change up inclusions, exclusions, and best practices from PR fee…
Browse files Browse the repository at this point in the history
…dback.
  • Loading branch information
perrygoy committed Sep 26, 2023
1 parent ed5b3bc commit 6caa50f
Showing 1 changed file with 10 additions and 13 deletions.
23 changes: 10 additions & 13 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ select = [
"FBT", # flake8-boolean-trap
"FIX", # flake8-fixme
"FLY", # flynt
"FURB", # refurb
"I", # isort
"ICN", # flake8-import-conventions
"ISC", # flake8-implicit-str-concat
Expand All @@ -141,32 +140,30 @@ select = [
"UP", # python upgrade
"W", # pycodestyle warning
"YTT", # flake8-2020

# we would like these someday, but not yet
# "FURB", # refurb
]
ignore = [
"D107", # missing __init__ docstring, we do that in the class docstring.
"D203", # one blank line before class; we want 2!
"D203", # one blank line before class docstring, no thanks!
"D212", # multi line summary first line, we want a one line summary.
"ANN101", # missing self annotation, we only annotate self when we return it.
"ANN401", # no `**kwargs: Any` typing; unfortunately we don't have a better way.
]
include = [
"screenpy",
"tests",
]
exclude = [
"screenpy/__init__.py",
"screenpy/__version__.py",
"docs",
]


[tool.ruff.per-file-ignores]
"__init__.py" = ["F401"]
"tests/ui/admin/budget_configure/modal*.py" = ["F401"]
"tests/ui/admin/organization_configure/modal*.py" = ["F401"]
"tests/ui/admin/schedule_configure/modal*.py" = ["F401"]
"setup/dbutil.py" = ["E722"] # bare except
"tests/question/new_expected_conditions.py" = ["ANN"] # this is a copy of the original

"tests/**" = [
"D", # we don't need public-API-polished docstrings in tests.
"FBT", # using a boolean as a test object is useful!
"PLR", # likewise using specific numbers and strings in tests.
]

[tool.ruff.isort]
combine-as-imports = true
Expand Down

0 comments on commit 6caa50f

Please sign in to comment.